Add migration to set IsArchived false if it is null #11853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#11824 Signed-off-by: Andrew Thornton <[email protected]>
|
I've set this as backport as I believe that we can still do this. |
GiteaBot
added
the
lgtm/need 2
|
@zeripath I think this is a task for doctor? |
|
(DB Consistency) |
|
Sadly we cannot backport this migration due to KeepActivityPrivate migration not being present in 1.12 |
techknowlogick
approved these changes
Jun 11, 2020
GiteaBot
added
lgtm/need 1
|
I guess we add it to doctor then. |
Signed-off-by: Andrew Thornton <[email protected]>
|
Is models/migrations/v142.go migration still needed? |
|
Yes, as it means that users don't have to run doctor. |
6543
approved these changes
Jun 11, 2020
GiteaBot
added
lgtm/done
|
I would still add the backport lable since we can partialy backport the doctor part |
|
ping LG-TM |
|
@zeripath please backport doctor changes :) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jun 11, 2020
…ort go-gitea#11853) Partial backport of go-gitea#11853 Add doctor check to set IsArchived false if it is null. (Migration change unfortunately not possible to be backported.) Fix go-gitea#11824 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
pushed a commit
that referenced
this pull request
Jun 11, 2020
…ort #11853) (#11859) Partial backport of #11853 Add doctor check to set IsArchived false if it is null. (Migration change unfortunately not possible to be backported.) Fix #11824 Signed-off-by: Andrew Thornton <[email protected]>
Closed
7 tasks
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Add migration to set IsArchived false if it is null Fix go-gitea#11824 Signed-off-by: Andrew Thornton <[email protected]> * Add doctor Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
7 tasks
Closed
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11824
Signed-off-by: Andrew Thornton [email protected]