Prevent panic on empty HOST for mysql #11850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
|
I think this is correct and that the go-sql-driver/mysql will work fine with an empty host - however, I will happily defer to those who know better. |
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Jun 11, 2020
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Jun 11, 2020
GiteaBot
added
lgtm/done
|
ping LG-TM |
|
@zeripath please send backport :) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jun 11, 2020
Backport go-gitea#11850 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
pushed a commit
that referenced
this pull request
Jun 11, 2020
Backport #11850 Signed-off-by: Andrew Thornton <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11754
Signed-off-by: Andrew Thornton [email protected]