Handle more pathological branch and tag names #11843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
|
Integration tests failing |
GiteaBot
added
the
lgtm/need 2
|
Yet again we are bitten by the problem that half the integrations tests don't use repositories properly. |
Signed-off-by: Andrew Thornton <[email protected]>
|
OK so there was a real issue - in addition to the test being broken - I had missed that we removed the deleted branch reference from the table which of course we no longer have to do as the push does that for us. |
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Jun 11, 2020
GiteaBot
added
lgtm/done
|
ping LG-TM |
|
@zeripath please send backport :) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jun 12, 2020
Backport go-gitea#11843 It's possible to push quite pathological appearing branch names to gitea using git push gitea reasonable-branch:refs/heads/-- at which point large parts of the UI will break. Similarly you can git push origin reasonable-tag:refs/tags/-- which wil return an error. This PR fixes the problems these cause. It also changes the code from creating branches to pushing to ensure that branch restoration has to pass hooks. Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
added a commit
that referenced
this pull request
Jun 12, 2020
Backport #11843 It's possible to push quite pathological appearing branch names to gitea using git push gitea reasonable-branch:refs/heads/-- at which point large parts of the UI will break. Similarly you can git push origin reasonable-tag:refs/tags/-- which wil return an error. This PR fixes the problems these cause. It also changes the code from creating branches to pushing to ensure that branch restoration has to pass hooks. Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Handle more pathological branch and tag names Signed-off-by: Andrew Thornton <[email protected]> * Fix failing test Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to push quite pathological appearing branch names to gitea using
git push gitea reasonable-branch:refs/heads/--at which point large parts of the UI will break. Similarly you cangit push origin reasonable-tag:refs/tags/--which wil return an error.This PR fixes the problems these cause. It also changes the code from creating branches to pushing to ensure that branch restoration has to pass hooks.
Signed-off-by: Andrew Thornton [email protected]