-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search form button overlap #11840
Conversation
I just concluded this as a fomantic bug and came up with this fix ( .search-column .ui.input input {
width: auto !important;
} |
Unsure if it's considered bug or just improper usage of nesting, I'd lean towards latter tho. |
For what it's worth my PR also fixes the alignment issue which was also introduced by linked PR (as it seems that Fomantic no longer calculated whole size of input and button but only input) |
The change makes search bar smaller due to that but that matches behavior from 1.11 before bug was introduced. |
The fomantic docs do recommend a parent for input with action: <div class="ui action input">
<input type="text" placeholder="Search...">
<button class="ui button">Search</button>
</div> |
And it is in one <div class="ui search fluid action input"> But one of input elements and button were nested twice. |
Ah, I see, so the double parent was what's causing the issue. |
ping LG-TM |
Should backport this. |
please send backport |
Co-authored-by: techknowlogick <[email protected]> (cherry picked from commit 8770bce)
Co-authored-by: techknowlogick <[email protected]> (cherry picked from commit 8770bce)
Co-authored-by: techknowlogick <[email protected]>
Fixes #11832
Introduced by #11385
I have no idea why the input was originally in it own div element