Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search form button overlap #11840

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jun 10, 2020

Fixes #11832

Introduced by #11385

I have no idea why the input was originally in it own div element

@silverwind
Copy link
Member

silverwind commented Jun 10, 2020

I just concluded this as a fomantic bug and came up with this fix (.search-column is a class added on the parent .column):

.search-column .ui.input input {
    width: auto !important;
}

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 10, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 10, 2020

Unsure if it's considered bug or just improper usage of nesting, I'd lean towards latter tho.

@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 10, 2020

For what it's worth my PR also fixes the alignment issue which was also introduced by linked PR (as it seems that Fomantic no longer calculated whole size of input and button but only input)

@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 10, 2020

The change makes search bar smaller due to that but that matches behavior from 1.11 before bug was introduced.

@silverwind
Copy link
Member

The fomantic docs do recommend a parent for input with action:

<div class="ui action input">
  <input type="text" placeholder="Search...">
  <button class="ui button">Search</button>
</div>

@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 10, 2020

And it is in one

<div class="ui search fluid action input">

But one of input elements and button were nested twice.

@silverwind
Copy link
Member

Ah, I see, so the double parent was what's causing the issue.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 10, 2020
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 10, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jun 10, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2020
@techknowlogick techknowlogick merged commit 8770bce into go-gitea:master Jun 12, 2020
@CirnoT CirnoT deleted the search-button branch June 12, 2020 07:00
@silverwind
Copy link
Member

Should backport this.

@lafriks
Copy link
Member

lafriks commented Jun 12, 2020

please send backport

CirnoT added a commit to CirnoT/gitea that referenced this pull request Jun 12, 2020
Co-authored-by: techknowlogick <[email protected]>
(cherry picked from commit 8770bce)
zeripath pushed a commit that referenced this pull request Jun 12, 2020
Co-authored-by: techknowlogick <[email protected]>
(cherry picked from commit 8770bce)
@zeripath zeripath added the backport/done All backports for this PR have been created label Jul 1, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue search button overlapped by another element and only partially clickable
6 participants