Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DEFAULT_PAGING_NUM instead of MAX_RESPONSE_ITEMS in ListOptions #11831

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Use DEFAULT_PAGING_NUM instead of MAX_RESPONSE_ITEMS in ListOptions #11831

merged 2 commits into from
Jun 10, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jun 10, 2020

Fixes setDefaultValues to use same logic as ToCorrectPageSize

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 10, 2020
@zeripath zeripath added modifies/api This PR adds API routes or modifies them type/bug labels Jun 10, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 2b2b3e4 into go-gitea:master Jun 10, 2020
@CirnoT CirnoT deleted the api-pagesize0 branch June 10, 2020 16:23
CirnoT added a commit to CirnoT/gitea that referenced this pull request Jun 10, 2020
@CirnoT
Use DEFAULT_PAGING_NUM instead of MAX_RESPONSE_ITEMS in ListOptions (g…
a961546 
…o-gitea#11831)

Co-authored-by: techknowlogick <[email protected]>
(cherry picked from commit 2b2b3e4)
@CirnoT CirnoT mentioned this pull request Jun 10, 2020
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jun 10, 2020
techknowlogick pushed a commit that referenced this pull request Jun 10, 2020
@CirnoT
Use DEFAULT_PAGING_NUM instead of MAX_RESPONSE_ITEMS in ListOptions (#…
56660c3 
…11831) (#11836)

Co-authored-by: techknowlogick <[email protected]>
(cherry picked from commit 2b2b3e4)
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @techknowlogick
Use DEFAULT_PAGING_NUM instead of MAX_RESPONSE_ITEMS in ListOptions (g…
26bb724 
…o-gitea#11831)

Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CirnoT @techknowlogick @zeripath @GiteaBot