Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doer of rename repo #11789

Merged
merged 2 commits into from
Jun 7, 2020
Merged

Fix doer of rename repo #11789

merged 2 commits into from
Jun 7, 2020

Conversation

a1012112796
Copy link
Member

As title

fix #11725

@a1012112796
Copy link
Member Author

By the way, I found the icon type of "ActionRenameRepo” is not defined. How about using “octicon-repo"? Thanks.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 7, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 7, 2020
@lafriks lafriks added type/bug lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 7, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 7, 2020
6543
6543 approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 7, 2020
@lafriks
Copy link
Member

lafriks commented Jun 7, 2020

Make lgtm work

@lafriks lafriks merged commit ba8efe3 into go-gitea:master Jun 7, 2020
@lafriks
Copy link
Member

lafriks commented Jun 7, 2020

Please send backport

@a1012112796 a1012112796 deleted the fix_rename_feed branch June 7, 2020 15:49
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jun 7, 2020
@a1012112796 @zeripath
Fix doer of rename repo (go-gitea#11789)
554a2b6 
fix go-gitea#11725

Signed-off-by: a1012112796 <[email protected]>

Co-authored-by: zeripath <[email protected]>
@a1012112796 a1012112796 mentioned this pull request Jun 7, 2020
Merged
lafriks pushed a commit that referenced this pull request Jun 7, 2020
@a1012112796 @zeripath
Fix doer of rename repo (#11789) (#11794)
99f7ec8 
fix #11725

Signed-off-by: a1012112796 <[email protected]>

Co-authored-by: zeripath <[email protected]>

Co-authored-by: zeripath <[email protected]>
@lafriks lafriks added the backport/done All backports for this PR have been created label Jun 7, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@a1012112796 @zeripath
Fix doer of rename repo (go-gitea#11789)
e38eba1 
fix go-gitea#11725

Signed-off-by: a1012112796 <[email protected]>

Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

User is not shown on rename
5 participants
@a1012112796 @lafriks @zeripath @6543 @GiteaBot