Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing CGO_EXTRA_FLAGS build arg for docker #11782

Merged
merged 2 commits into from
Jun 6, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jun 6, 2020

Necessary so people can specify custom CGO flags for docker builds, just like in Makefile.

@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jun 6, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 6, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2020
@lafriks
Copy link
Member

lafriks commented Jun 6, 2020

make lg-tm work

@techknowlogick techknowlogick merged commit 594db7f into go-gitea:master Jun 6, 2020
@CirnoT CirnoT deleted the cgo-extra-flags branch June 6, 2020 22:03
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants