Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update emoji dataset with skin tone variants (#11678) #11763

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Update emoji dataset with skin tone variants (#11678) #11763

merged 1 commit into from
Jun 4, 2020

Conversation

mrsdizzie
Copy link
Member

Backport #11678

@mrsdizzie @techknowlogick
Update emoji dataset with skin tone variants (go-gitea#11678)
e9c847a 
* Update emoji dataset with skin tone variants

Since the format of emoji that support skin tone modifiers is predictable we can add different variants into our dataset when generating it so that we can match and properly style most skin tone variants of emoji. No real code change here other than what generates the dataset and the data itself.

* use escape unicode sequence in map

Co-authored-by: techknowlogick <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 4, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jun 4, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jun 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2020
@guillep2k guillep2k merged commit 0ad4083 into go-gitea:release/v1.12 Jun 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mrsdizzie @techknowlogick @zeripath @guillep2k @GiteaBot