Initialize SimpleMDE when making a code comment #11749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#11704 Signed-off-by: Andrew Thornton <[email protected]>
6543
approved these changes
Jun 4, 2020
GiteaBot
added
the
lgtm/need 1
silverwind
reviewed
Jun 4, 2020
|
|
||
| // Give new write/preview data-tab name to distinguish from others | ||
| const $simplemde = setCommentSimpleMDE($textarea); | ||
| $textarea.focus(); |
There was a problem hiding this comment.
it's copying the same code as the $('.edit-content').on('click', async function (event) {...}
There was a problem hiding this comment.
Seems like a noop to me unless the textarea focus triggers something, but whatever.
There was a problem hiding this comment.
I agree it's likely a no-op - but's it's present elsewhere and so I think it's prudent to put it there in case it's there for a reason. I don't want to introduce a new heisenbug.
silverwind
reviewed
Jun 4, 2020
|
Still broken for reply |
|
Needs styling fixes now as currently it has been styled to match textarea only Index: web_src/less/_review.less
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- web_src/less/_review.less (revision 0814066a3e59714ab5d4790ceefe3477c7178c72)
+++ web_src/less/_review.less (date 1591292279994)
@@ -54,15 +54,14 @@
border: 0;
padding: 0;
margin: 0;
-
- &.markdown {
- padding: 1em;
- min-height: 168px;
- }
}
&.header {
padding: .1rem 1rem;
+
+ .text {
+ margin: 0;
+ }
}
}
@@ -76,18 +75,16 @@
}
.ui.active.tab {
- border: 1px solid #d4d4d5;
padding: .5em;
- border-radius: 0 .28571429rem .28571429rem;
- }
- .ui.active.markdown.tab {
- border-top-left-radius: .28571429rem;
+ &.markdown {
+ padding: 1em;
+ min-height: 168px;
+ }
}
.ui.tabular.menu {
- margin-bottom: 0;
- border-bottom: 0;
+ margin: .5em;
}
.comment-list { |
zeripath
commented
Jun 4, 2020
Co-Authored-By: Cirno the Strongest <[email protected]> Signed-off-by: Andrew Thornton <[email protected]>
…thub.com:zeripath/gitea into fix-11704-initialize-simplemde-for-code-comments
…e-simplemde-for-code-comments
|
Still broken for replying to code comments
|
|
I wasn't aware that was broken at all... |
|
Markdown bar is shown now on edit and creation, so it makes sense that it would be shown for replies too. |
Signed-off-by: Andrew Thornton <[email protected]>
|
done |
CirnoT
approved these changes
Jun 6, 2020
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jun 6, 2020
Backport go-gitea#11749 Fix go-gitea#11704 Signed-off-by: Andrew Thornton <[email protected]> Co-Authored-By: Cirno the Strongest <[email protected]>
techknowlogick
added a commit
that referenced
this pull request
Jun 7, 2020
Backport #11749 Fix #11704 Signed-off-by: Andrew Thornton <[email protected]> Co-Authored-By: Cirno the Strongest <[email protected]> Co-authored-by: Cirno the Strongest <[email protected]> Co-authored-by: techknowlogick <[email protected]>
|
Need label backport/done |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Fix go-gitea#11704 Signed-off-by: Andrew Thornton <[email protected]> Co-Authored-By: Cirno the Strongest <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11704
Signed-off-by: Andrew Thornton [email protected]