Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing check for #11111 backport #11693

Merged
merged 1 commit into from
May 30, 2020
Merged

Add missing check for #11111 backport #11693

merged 1 commit into from
May 30, 2020

Conversation

guillep2k
Copy link
Member

#11138 partially backported some checks, but a check for database version was missing. This PR backports that part.

Co-authored-by: @6543

@guillep2k guillep2k added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 30, 2020
@guillep2k guillep2k added this to the 1.11.6 milestone May 30, 2020
@6543
Copy link
Member

6543 commented May 30, 2020

@guillep2k pleace add abortIfFailed: false, to
https://github.com/go-gitea/gitea/blob/release/v1.11/cmd/doctor.go#L116-L121

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2020
@guillep2k
Copy link
Member Author

guillep2k commented May 30, 2020 •
edited
Loading

@guillep2k pleace add abortIfFailed: false, to
https://github.com/go-gitea/gitea/blob/release/v1.11/cmd/doctor.go#L116-L121

I don't see the point. If we ever backport new checks, most likely those checks won't depend on the times being fixed.

IMHO the abortIfFailed flag is flawed because the user can specify the checks to run and skip any failing checks.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 30, 2020
@guillep2k guillep2k merged commit 161e550 into go-gitea:release/v1.11 May 30, 2020
@guillep2k guillep2k deleted the bakport-11111-check branch May 30, 2020 15:55
@snyk-bot snyk-bot mentioned this pull request Nov 18, 2020
Open
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.11.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guillep2k @6543 @zeripath @GiteaBot