Fix language stat calculation #11692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
Okay, after going through some tests and discovering some weird behaviors whereas GitHub does not recalculate old repos I make these changes:
I've tested it on mirror repo from GH and the stats are 1:1 identical in database with what GH shows via API. |
lafriks
approved these changes
May 30, 2020
GiteaBot
added
lgtm/need 1
guillep2k
reviewed
May 30, 2020
guillep2k
approved these changes
May 30, 2020
GiteaBot
added
lgtm/done
lafriks
pushed a commit
to lafriks-fork/gitea
that referenced
this pull request
Jun 1, 2020
* Fix language stat calculation * Group languages and ignore 0 size files * remove unneeded code
lafriks
added a commit
that referenced
this pull request
Jun 2, 2020
#11690) * Change language statistics to save size instead of percentage (#11681) * Change language statistics to save size instead of percentage in database Co-Authored-By: Cirno the Strongest <[email protected]> * Do not exclude if only language * Fix edge cases with special langauges Co-authored-by: Cirno the Strongest <[email protected]> * Fix language stat calculation (#11692) * Fix language stat calculation * Group languages and ignore 0 size files * remove unneeded code Co-authored-by: Cirno the Strongest <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix language stat calculation * Group languages and ignore 0 size files * remove unneeded code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord; #11681 broke primary language selection by storing excluded languages in database along with explicit "other".
This PR makes it so that "other" and excluded languages are not stored in database allowing us to replicate languages API the same way GitHub does.