Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing authorization check on pull for public repos of private/limited org #11656

Merged
merged 11 commits into from
May 29, 2020
Merged

Fix missing authorization check on pull for public repos of private/limited org #11656

merged 11 commits into from
May 29, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 28, 2020

Fixes #11651

jolheiser
jolheiser reviewed May 28, 2020
View reviewed changes
routers/repo/http.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 28, 2020
@lafriks lafriks added type/bug topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! backport/v1.12 labels May 28, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 28, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 28, 2020

Might need backport to v1.11 too

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2020
@guillep2k
Copy link
Member

Somehow this broke TestGit/HTTP/PushCreate

@CirnoT
Copy link
Contributor Author

CirnoT commented May 28, 2020

Should be fixed

@guillep2k
Copy link
Member

Ping LG-TM

@zeripath
Copy link
Contributor

make lg-tm

@zeripath zeripath merged commit 02fa329 into go-gitea:master May 29, 2020
@zeripath
Copy link
Contributor

Please send backports to 1.12 and 1.11

@CirnoT CirnoT deleted the private-repo-pull branch May 29, 2020 18:38
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 29, 2020
@CirnoT
Fix missing authorization check on pull for public repos of private/l…
93fe03f 
…imited org (go-gitea#11656)

Fixes go-gitea#11651

(cherry picked from commit 02fa329)
@CirnoT CirnoT mentioned this pull request May 29, 2020
Merged
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 29, 2020
@CirnoT
Fix missing authorization check on pull for public repos of private/l…
d45d0fc 
…imited org (go-gitea#11656)

Fixes go-gitea#11651

(cherry picked from commit 02fa329)
@CirnoT CirnoT mentioned this pull request May 29, 2020
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label May 29, 2020
techknowlogick pushed a commit that referenced this pull request May 29, 2020
@CirnoT
Fix missing authorization check on pull for public repos of private/l…
6ad0d0a 
…imited org (#11656) (#11682)

Fixes #11651

(cherry picked from commit 02fa329)
zeripath pushed a commit that referenced this pull request May 29, 2020
@CirnoT
Fix missing authorization check on pull for public repos of private/l…
95af609 
…imited org (#11656) (#11683)

Fixes #11651

(cherry picked from commit 02fa329)
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT
Fix missing authorization check on pull for public repos of private/l…
16ba303 
…imited org (go-gitea#11656)

Fixes go-gitea#11651
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Public repositories of non-public organizations can be cloned by anonymous user
7 participants
@CirnoT @guillep2k @zeripath @lafriks @6543 @jolheiser @GiteaBot