Add logging to long migrations #11647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix v136 to not use models Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/enhancement
|
Although an enhancement I think this should be backported because some of these migrations take time and people have complained about poor logging in these already. |
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
May 27, 2020
GiteaBot
added
lgtm/need 1
|
So this is weird I'm getting a log timeout for test ... |
|
It will may pass if #11646 was merged? |
Signed-off-by: Andrew Thornton <[email protected]>
|
@6543 the issue was that I had made it so that the migrations never actually finished! Fixed now! |
zeripath
commented
May 29, 2020
zeripath
commented
May 29, 2020
zeripath
commented
May 29, 2020
zeripath
commented
May 29, 2020
CirnoT
approved these changes
May 29, 2020
GiteaBot
added
lgtm/done
|
Make lg-tm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 30, 2020
* Add logging to long migrations Also fix v136 to not use models Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
pushed a commit
that referenced
this pull request
May 31, 2020
* Add logging to long migrations Also fix v136 to not use models Signed-off-by: Andrew Thornton <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Add logging to long migrations Also fix v136 to not use models Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix v136 to not use models
Closes #11645
Signed-off-by: Andrew Thornton [email protected]