Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport various styling fixes #11619

Merged
merged 5 commits into from
May 26, 2020
Merged

Backport various styling fixes #11619

merged 5 commits into from
May 26, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 25, 2020

@CirnoT
Fix inconsistent font size for markdown preview on new PR view (go-gi…
84d2718 
…tea#11565)

We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size.

(cherry picked from commit 04afd9d)
@CirnoT
Fix margin on PR form (go-gitea#11566)
7990878 
(cherry picked from commit f2a0be1)
@CirnoT
Fix margin for attached top header on code review (go-gitea#11571)
30feee2 
Introduced naively by go-gitea#11463

The margin was being applied too widely.

(cherry picked from commit e682a92)
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels May 25, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone May 25, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 25, 2020
@CirnoT
Fix styling for PR merge section when no checks (go-gitea#11609)
0b778cc 
Makes styling consistent between two cases. Also removed unnecessary double border.
@CirnoT
Copy link
Contributor Author

CirnoT commented May 25, 2020

Added backport for #11609

@lafriks
Copy link
Member

lafriks commented May 25, 2020

You can add also #11589

@CirnoT
Copy link
Contributor Author

CirnoT commented May 25, 2020

Done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 25, 2020
@techknowlogick techknowlogick merged commit 5331af1 into go-gitea:release/v1.12 May 26, 2020
@CirnoT CirnoT deleted the bp-bundle branch May 26, 2020 06:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@CirnoT @lafriks @silverwind @zeripath @techknowlogick @GiteaBot