When must change password only show signout button in header #11600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "Must Change Password" simplify the navbar header to only show the signout button as all other links will redirect back. This prevents the notifications icon from showing preventing initialization of the event-source and hence preventing redirect_to being set, however in addition do not set the redirect_to cookie if we are looking at the /user/events page. Fix go-gitea#11554 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
approved these changes
May 25, 2020
GiteaBot
added
the
lgtm/need 1
guillep2k
approved these changes
May 26, 2020
GiteaBot
added
lgtm/done
…ssword-for-user-events
|
Make lg-tm work |
guillep2k
pushed a commit
to guillep2k/gitea
that referenced
this pull request
May 26, 2020
When "Must Change Password" simplify the navbar header to only show the signout button as all other links will redirect back. This prevents the notifications icon from showing preventing initialization of the event-source and hence preventing redirect_to being set, however in addition do not set the redirect_to cookie if we are looking at the /user/events page. Fix go-gitea#11554 Signed-off-by: Andrew Thornton <[email protected]>
lafriks
reviewed
May 26, 2020
| {{if .IsSigned}} | ||
| {{if and .IsSigned .MustChangePassword}} | ||
| {{/* No links */}} | ||
| {{else if .IsSigned}} |
There was a problem hiding this comment.
It could be just simplified to if and .IsSigned (not .MustChangePassword) to not need empty if
There was a problem hiding this comment.
I considered that and originally wrote that but thought it better to be explicit and for the if statement to match the next one. We'd only have to write a two line comment to explain.
zeripath
added a commit
that referenced
this pull request
May 27, 2020
When "Must Change Password" simplify the navbar header to only show the signout button as all other links will redirect back. This prevents the notifications icon from showing preventing initialization of the event-source and hence preventing redirect_to being set, however in addition do not set the redirect_to cookie if we are looking at the /user/events page. Fix #11554 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: zeripath <[email protected]>
zeripath
deleted the
fix-11554-do-not-set-redirect-to-change-password-for-user-events
branch
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
When "Must Change Password" simplify the navbar header to only show the signout button as all other links will redirect back. This prevents the notifications icon from showing preventing initialization of the event-source and hence preventing redirect_to being set, however in addition do not set the redirect_to cookie if we are looking at the /user/events page. Fix go-gitea#11554 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "Must Change Password" simplify the navbar header to only show the Signout button as all other links will redirect back in any case.
This prevents the notifications icon from showing preventing initialization of the event-source and hence preventing redirect_to being set, however in addition do not set the
redirect_tocookie if we are looking at the/user/eventspage.Fix #11554
Signed-off-by: Andrew Thornton [email protected]