Add auto-generated serviceworker.js to .gitignore #11567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
approved these changes
May 23, 2020
GiteaBot
added
the
lgtm/need 1
|
Ah, this explains why I did not notice the issue described in #11562 (comment) earlier. It was using the file from the devbuild when I did the prod build. Made sure issues like that can not happen anymore in 376988d. |
|
Could you move it one line above? Seems more logical to have the public entries together. |
lafriks
added
the
topic/build
lafriks
approved these changes
May 23, 2020
GiteaBot
added
lgtm/done
|
Closed by #11577 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #11538
Needs backport to v1.12