Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent transferring repos to invisible orgs (#11517) #11549

Merged
merged 5 commits into from
May 23, 2020
Merged

Prevent transferring repos to invisible orgs (#11517) #11549

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82f20de
Prevent transferring repos to invisible orgs (#11517)
guillep2k May 21, 2020
442aa6d
Merge branch 'release/v1.12' into backport-11517
zeripath May 22, 2020
1245377
Merge branch 'release/v1.12' into backport-11517
guillep2k May 22, 2020
5bda80e
Merge branch 'release/v1.12' into backport-11517
guillep2k May 22, 2020
5efba91
Merge branch 'release/v1.12' into backport-11517
zeripath May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Prevent transferring repos to invisible orgs (#11517) 
Co-authored-by: Guillermo Prandi <[email protected]>
  • Loading branch information
@guillep2k
guillep2k and guillep2k committed May 22, 2020
commit 82f20ded3605e04d60b1bb24758617ae300660e3
9 changes: 9 additions & 0 deletions routers/repo/setting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/repository"
"code.gitea.io/gitea/modules/setting"
"code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/modules/timeutil"
"code.gitea.io/gitea/modules/validation"
"code.gitea.io/gitea/routers/utils"
Expand Down Expand Up @@ -379,6 +380,14 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
return
}

if newOwner.Type == models.UserTypeOrganization {
if !ctx.User.IsAdmin && newOwner.Visibility == structs.VisibleTypePrivate && !ctx.User.IsUserPartOfOrg(newOwner.ID) {
// The user shouldn't know about this organization
ctx.RenderWithErr(ctx.Tr("form.enterred_invalid_owner_name"), tplSettingsOptions, nil)
return
}
}

// Close the GitRepo if open
if ctx.Repo.GitRepo != nil {
ctx.Repo.GitRepo.Close()
Expand Down