Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure emoji render with regular font-weight #11541

Merged
merged 1 commit into from
May 22, 2020
Merged

Ensure emoji render with regular font-weight #11541

merged 1 commit into from
May 22, 2020

Conversation

silverwind
Copy link
Member

Emoji characters don't support bold attributes and may do weird things like rendering monochrome when bolded.

@silverwind
Ensure emoji render with regular font-weight
a230e31 
Emoji characters don't support bold attributes and may do weird things
like rendering monochrome when bolded.
@guillep2k
Copy link
Member

Only for reactions? 🤔

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2020
@guillep2k guillep2k added type/bug topic/ui Change the appearance of the Gitea UI labels May 21, 2020
@guillep2k guillep2k added this to the 1.13.0 milestone May 21, 2020
@silverwind
Copy link
Member Author

@guillep2k click "Expand Up" in the diff 😉

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2020
@guillep2k guillep2k merged commit 035db78 into go-gitea:master May 22, 2020
@guillep2k
Copy link
Member

Please send backport

silverwind added a commit to silverwind/gitea that referenced this pull request May 22, 2020
@silverwind
Ensure emoji render with regular font-weight (go-gitea#11541)
e7e8d9a 
Emoji characters don't support bold attributes and may do weird things
like rendering monochrome when bolded.
@silverwind silverwind mentioned this pull request May 22, 2020
Merged
zeripath pushed a commit that referenced this pull request May 22, 2020
@silverwind
Ensure emoji render with regular font-weight (#11541) (#11545)
2042cf2 
Emoji characters don't support bold attributes and may do weird things
like rendering monochrome when bolded.
@zeripath zeripath added the backport/done All backports for this PR have been created label May 29, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind
Ensure emoji render with regular font-weight (go-gitea#11541)
6e81518 
Emoji characters don't support bold attributes and may do weird things
like rendering monochrome when bolded.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CirnoT CirnoT CirnoT approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@silverwind @guillep2k @CirnoT @mrsdizzie @lafriks @zeripath @GiteaBot