Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move serviceworker to workbox and fix SSE interference #11538

Merged
merged 13 commits into from
May 22, 2020
Merged

Move serviceworker to workbox and fix SSE interference #11538

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
99d9b0f
Move serviceworker to workbox and fix SSE interference
silverwind May 21, 2020
043162b
rethrow error instead of logging
silverwind May 21, 2020
195e97e
await .register
silverwind May 21, 2020
755b835
Revert "rethrow error instead of logging"
silverwind May 21, 2020
9393219
improve comment
silverwind May 21, 2020
fbb93af
Merge branch 'master' into workbox
guillep2k May 22, 2020
bb8515e
remove JSRenderer
silverwind May 22, 2020
8636e47
Merge branch 'master' into workbox
guillep2k May 22, 2020
5113a3d
add version-based cache invalidation
silverwind May 22, 2020
d0ff22c
refactor
silverwind May 22, 2020
d2716c9
more refactor
silverwind May 22, 2020
efb0201
remove comment
silverwind May 22, 2020
518f6e9
rename item to fit cache name
silverwind May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve comment
  • Loading branch information
@silverwind
silverwind committed May 21, 2020
commit 9393219c39174a88fb6f1d0fffb2b5ddac494487
4 changes: 2 additions & 2 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ module.exports = {
output: {
path: resolve(__dirname, 'public'),
filename: ({chunk}) => {
// serviceworker can only manage assets below it's script path so we
// have to put it in / instead of /js/
// serviceworker can only manage assets below it's script's directory so
// we have to put it in / instead of /js/
return chunk.id === 'serviceworker' ? '[name].js' : 'js/[name].js';
},
chunkFilename: 'js/[name].js',
Expand Down