Fix repo-list private and total count bugs #11500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
|
(Fixes bugs reported by @CirnoT) |
GiteaBot
added
the
lgtm/need 2
|
Public repos of limited/private organizations still don't show as either Private or Public, only in undefined state. |
|
Sigh ... I've set it so that "private" shows the limited and private org public repos. |
|
I don't think I agree with them being classified as private, considering they are currently shown as public (both via icon as well as color); I think user expectation given visual clues would be that they show under Public |
|
this is kind/breaking for the API !!! |
|
OnlyPrivate -> AndPrivate or am I'm wrong? |
|
but of course this still doesn't completely work... pub repo of pub org seems not be shown. |
|
WHY IS THIS SUCH A MESS |
Signed-off-by: Andrew Thornton <[email protected]>
6543
approved these changes
May 20, 2020
GiteaBot
added
lgtm/need 1
|
|
6543
reviewed
May 20, 2020
Signed-off-by: Andrew Thornton <[email protected]>
lafriks
approved these changes
May 20, 2020
GiteaBot
added
lgtm/done
CirnoT
approved these changes
May 20, 2020
guillep2k
approved these changes
May 21, 2020
|
Please send backport |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 21, 2020
* Fix repo-list private and total count bugs Signed-off-by: Andrew Thornton <[email protected]> * Ensure limited and private org public repos are displayed on "private" Signed-off-by: Andrew Thornton <[email protected]> * switch from onlyPrivate to is_private Signed-off-by: Andrew Thornton <[email protected]> * Generate swagger Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: guillep2k <[email protected]>
jolheiser
pushed a commit
that referenced
this pull request
May 21, 2020
* Fix repo-list private and total count bugs Signed-off-by: Andrew Thornton <[email protected]> * Ensure limited and private org public repos are displayed on "private" Signed-off-by: Andrew Thornton <[email protected]> * switch from onlyPrivate to is_private Signed-off-by: Andrew Thornton <[email protected]> * Generate swagger Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: guillep2k <[email protected]> Co-authored-by: guillep2k <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix repo-list private and total count bugs Signed-off-by: Andrew Thornton <[email protected]> * Ensure limited and private org public repos are displayed on "private" Signed-off-by: Andrew Thornton <[email protected]> * switch from onlyPrivate to is_private Signed-off-by: Andrew Thornton <[email protected]> * Generate swagger Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: guillep2k <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with the repo-list total count number not showing up and just sets the "private" toggle to match repo.is_private state.
A more complete refactor of these toggles is required in future but this is a simple backportable bug-fix
Signed-off-by: Andrew Thornton [email protected]