[Frontend] Make localstorage read ssh or https correctly

[L0veSunshine]

The localstorage has stored the user's option of repo's link type, but it don't read correctly.
This pr fix it : when you select the ssh type link, all repo links you enter later are displayed in ssh form.

The ui about this pr is here:

[CirnoT]

Why have effectively you changed the defaults to ssh by resetting it to that value when user selects HTTPS? Also, there's already code present to save the value on click, I don't see why you would want to set it on initialization.

[CirnoT]

Afraid I have to remove my approval with new changes

[L0veSunshine]

Why have effectively you changed the defaults to ssh by resetting it to that value when user selects HTTPS? Also, there's already code present to save the value on click, I don't see why you would want to set it on initialization.

Assume a situation. If you sign in and select "ssh" option. then you log out and view the repo's homepage. Your previous selection will be overwrite to "https".
That is why i do this change. I hope the selection will store without the login status influences.

[CirnoT]

• Logged out users default to HTTPS and don't see SSH button
• The change does nothing to fix the issue you mentioned , instead it forces SSH to be default ALWAYS, even if you click HTTPS it will reset to SSH after refresh.

[L0veSunshine]

• It is supposed to do that I believe, logged out users should default to HTTPS
• The change does nothing to fix that, instead it forces SSH to be default ALWAYS, even if you click HTTPS it will reset to SSH after refresh.

If you click the "https" your default selection will change. The "setitem sentence" will only do when the your selection is "ssh".

[L0veSunshine]

• It is supposed to do that I believe, logged out users should default to HTTPS
• The change does nothing to fix that, instead it forces SSH to be default ALWAYS, even if you click HTTPS it will reset to SSH after refresh.

If you click the "https" your default selection will change. The "setitem sentence" will only do when the your selection is "ssh".

The setitem under this code case 'ssh': . So it will not reset to SSH after refresh. It depends your selection.

[CirnoT]

You are right, it does work.

The check should be moved to $('#repo-clone-https').on('click' most likely however, as I believe there is no guarantee that your setItem will execute after click event has finished; so there is race condition there.

[CirnoT]

I meant something like this:

Index: web_src/js/index.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- web_src/js/index.js (revision 695a181b01d50235b80aa6c7077924a0708e5d9c)
+++ web_src/js/index.js (date 1589821225642)
@@ -1109,8 +1109,10 @@
     $('.clone-url').text($(this).data('link'));
     $('#repo-clone-url').val($(this).data('link'));
     $(this).addClass('blue');
-    $('#repo-clone-ssh').removeClass('blue');
-    localStorage.setItem('repo-clone-protocol', 'https');
+    if ($('#repo-clone-ssh').length > 0) {
+      $('#repo-clone-ssh').removeClass('blue');
+      localStorage.setItem('repo-clone-protocol', 'https');
+    }
   });
   $('#repo-clone-url').on('click', function () {
     $(this).select();
@@ -2440,7 +2442,6 @@
           $('#repo-clone-ssh').trigger('click');
         } else {
           $('#repo-clone-https').trigger('click');
-          localStorage.setItem('repo-clone-protocol', 'ssh');
         }
         break;
       default:

[L0veSunshine]

I meant something like this:

Index: web_src/js/index.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- web_src/js/index.js (revision 695a181b01d50235b80aa6c7077924a0708e5d9c)
+++ web_src/js/index.js (date 1589821225642)
@@ -1109,8 +1109,10 @@
     $('.clone-url').text($(this).data('link'));
     $('#repo-clone-url').val($(this).data('link'));
     $(this).addClass('blue');
-    $('#repo-clone-ssh').removeClass('blue');
-    localStorage.setItem('repo-clone-protocol', 'https');
+    if ($('#repo-clone-ssh').length > 0) {
+      $('#repo-clone-ssh').removeClass('blue');
+      localStorage.setItem('repo-clone-protocol', 'https');
+    }
   });
   $('#repo-clone-url').on('click', function () {
     $(this).select();
@@ -2440,7 +2442,6 @@
           $('#repo-clone-ssh').trigger('click');
         } else {
           $('#repo-clone-https').trigger('click');
-          localStorage.setItem('repo-clone-protocol', 'ssh');
         }
         break;
       default:

I just thought of this. I will change this.
Thanks for your advice.

[L0veSunshine]

It is ready for review. And thanks for the advice from @CirnoT.

[CirnoT]

Looks good to me now

[6543]

let @CirnoT lgtm count

[6543]

@L0veSunshine pleace send backport :)

[L0veSunshine]

Please review the new pr #11489. Also about "index.js" @CirnoT @6543

[L0veSunshine]

@L0veSunshine pleace send backport :)

I am very sorry, i don't know how to do that.

[6543]

@L0veSunshine:

if your local gitea repo hast your fork as remote named origin:

git remote add upstream https://github.com/go-gitea/gitea
git fetch --all
git checkout -f upstream/release/v1.12 -b backport_11483
git cherry-pick eb8abffcc1be777d38a416a030a6e4f42b06ac25
git push -u origin backport_11483

and then make a pull from your fork (branch backport_11483) to the gitea repo branch release/v1.12

witch result in:
#11490

ceers :)

this is of cours only one way to do it ...

[L0veSunshine]

@L0veSunshine:

if your local gitea repo hast your fork as remote named origin:

git remote add upstream https://github.com/go-gitea/gitea
git fetch --all
git checkout -f upstream/release/v1.12 -b backport_11483
git cherry-pick eb8abffcc1be777d38a416a030a6e4f42b06ac25
git push -u origin backport_11483

and then make a pull from your fork (branch backport_11483) to the gitea repo branch release/v1.12

witch result in:
#11490

ceers :)

this is of cours only one way to do it ...

Thank you for the tutorial. I will learn. Also thank to your help.