Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check branch protection on IsUserAllowedToUpdate #11448

Merged
merged 2 commits into from
May 17, 2020
Merged

Check branch protection on IsUserAllowedToUpdate #11448

merged 2 commits into from
May 17, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 17, 2020

close #11197

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 17, 2020
@zeripath zeripath added this to the 1.12.0 milestone May 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2020
@guillep2k guillep2k changed the title Check Push Permissions on IsUserAllowedToUpdate Check branch protection on IsUserAllowedToUpdate May 17, 2020
@6543
Copy link
Member Author

6543 commented May 17, 2020

🚀

@techknowlogick techknowlogick merged commit 84bcb34 into go-gitea:master May 17, 2020
@6543 6543 deleted the fix-IsUpdatable_11197 branch May 17, 2020 00:58
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Check Push permissions on IsUserAllowedToUpdate (go-gitea#11448)
a307531
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[Bug] on pull view: IsUpdatable does not check if HeadBranch is protected
5 participants
@6543 @zeripath @guillep2k @techknowlogick @GiteaBot