Fix margin on attached segment headers when they are separated by other element #11425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've mostly went around various places to verify that this does not break anything, but might have missed something. The alternative would be to ensure in templates that segments with headers are never separated from each other, which might not always be possible with granular templates we have. |
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
May 15, 2020
GiteaBot
added
lgtm/need 1
mrsdizzie
approved these changes
May 15, 2020
GiteaBot
added
lgtm/done
|
ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
…er element (go-gitea#11425) Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixed in #10235 however the issue was still present if the elements were separated with something else, which happens in user settings.
In this example first segment has proper margin, but the second one does not because there is confirmation modal between them.