Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yellow background on active elements in code review #11414

Merged
merged 5 commits into from
May 16, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 15, 2020

This PR ensures that yellow background on .active element is applied only to actual code lines.

Fixes this issue:
chrome_2020-05-15_02-18-00

chrome_2020-05-15_02-18-14

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 15, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 15, 2020
@lafriks lafriks added this to the 1.12.0 milestone May 15, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit d833ca3 into go-gitea:master May 16, 2020
@CirnoT CirnoT deleted the coder-yellow branch May 16, 2020 01:16
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants