Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore active background to Register button on Register page #11390

Merged
merged 1 commit into from
May 12, 2020
Merged

Restore active background to Register button on Register page #11390

merged 1 commit into from
May 12, 2020

Conversation

a1012112796
Copy link
Member

As title
ref code:

gitea/templates/base/head_navbar.tmpl

Line 130 in 08611fb

<a class="item{{if .PageIsSignUp}} active{{end}}" href="{{AppSubUrl}}/user/sign_up">

from:

tmpb

to:

tmpa

@a1012112796 a1012112796 changed the title ui: Replenish the missing ‘PageIsSignUp’ in sign up view bug: Replenish the missing ‘PageIsSignUp’ in sign up view May 12, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 12, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 12, 2020
@lafriks lafriks added this to the 1.12.0 milestone May 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2020
@zeripath zeripath merged commit b00e62c into go-gitea:master May 12, 2020
@zeripath zeripath changed the title bug: Replenish the missing ‘PageIsSignUp’ in sign up view Restore active background on Register button on Register page May 17, 2020
@zeripath zeripath changed the title Restore active background on Register button on Register page Restore active background to Register button on Register page May 17, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@a1012112796
ui: Replenish the missing ‘PageIsSignUp’ in sign up view (go-gitea#11390
efb52b9 
)

Signed-off-by: a1012112796 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@a1012112796 @lafriks @zeripath @GiteaBot