Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hook failure due to relative LFS_CONTENT_PATH #11362

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 10, 2020

Move LFS directory creation out of NewContext - this fixes hook and serv failures due to relative LFS_CONTENT_PATH

Fix #9481
(probably others too)

Signed-off-by: Andrew Thornton [email protected]

Fix go-gitea#9481
(probably others too)

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.12.0 milestone May 10, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #11362 into master will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11362      +/-   ##
==========================================
- Coverage   43.87%   43.83%   -0.04%     
==========================================
  Files         613      613              
  Lines       87226    87229       +3     
==========================================
- Hits        38272    38240      -32     
- Misses      44237    44266      +29     
- Partials     4717     4723       +6     
Impacted Files Coverage Δ
modules/setting/setting.go 45.53% <50.00%> (+0.25%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/eventsource/manager_run.go 73.07% <0.00%> (-11.54%) ⬇️
models/repo_mirror.go 2.12% <0.00%> (-10.64%) ⬇️
modules/indexer/code/git.go 55.17% <0.00%> (-4.32%) ⬇️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
services/pull/temp_repo.go 31.62% <0.00%> (-2.57%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
modules/git/repo.go 49.79% <0.00%> (-1.26%) ⬇️
modules/log/event.go 64.61% <0.00%> (-1.03%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb7497...326f51a. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2020
@lafriks
Copy link
Member

lafriks commented May 10, 2020

Make lgtm work

@lafriks lafriks merged commit f8e015e into go-gitea:master May 10, 2020
@zeripath zeripath deleted the move-creation-of-lfs-directory-out-of-NewContext branch May 10, 2020 14:07
@zeripath zeripath changed the title Move LFS directory creation out of NewContext Fix hook failure due to relative LFS_CONTENT_PATH May 17, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Fix go-gitea#9481
(probably others too)

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add --work-path to authorized_keys
5 participants