Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the style in admin notice content view from <p> to <pre> #11301

Merged
merged 1 commit into from
May 5, 2020

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented May 5, 2020

That's because many notic have more than one lines. So I think pre is more better to used in here than p

from:
f1

to:
f2

That's because many notic have more than one lines. So I think
pre is more better to used in here than p

Signed-off-by: a1012112796 <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 5, 2020
@jolheiser jolheiser added the topic/ui Change the appearance of the Gitea UI label May 5, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone May 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2020
@jolheiser jolheiser merged commit 0396fcf into go-gitea:master May 5, 2020
@jolheiser jolheiser changed the title ui: Change the style of content in notic content view from <p> to <pre> Change the style in admin notice content view from <p> to <pre> May 5, 2020
@6543
Copy link
Member

6543 commented May 5, 2020

wow this was fast :)

didnt come to test it

ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…itea#11301)

That's because many notic have more than one lines. So I think
pre is more better to used in here than p

Signed-off-by: a1012112796 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants