Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update snapcraft.yaml for core18 and latest features #11300

Merged
merged 6 commits into from
May 8, 2020

Conversation

sergiusens
Copy link
Contributor

Removing some of the complexity, together with the install and
configure hook.

Signed-off-by: Sergio Schvezov [email protected]

journalctl output:

May 05 06:24:20 umbar systemd[1]: Started Service for snap application gitea.web.
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 cmd/web.go:107:runWeb() [I] Starting Gitea on PID: 1503000
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 ...dules/setting/git.go:93:newGit() [I] Git Version: 2.17.1
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 routers/init.go:88:GlobalInit() [T] AppPath: /snap/gitea/x2/gitea
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 routers/init.go:89:GlobalInit() [T] AppWorkPath: /var/snap/gitea/x2
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 routers/init.go:90:GlobalInit() [T] Custom path: /var/snap/gitea/common
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 routers/init.go:91:GlobalInit() [T] Log path: /var/snap/gitea/x2/log
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 ...dules/setting/log.go:233:newLogService() [I] Gitea v1.12.0+dev-260-g0ba581dfa built with GNU Make 4.1, go1.14.2 : bindata, sqlite, sqlite>
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 ...dules/setting/log.go:276:newLogService() [I] Gitea Log Mode: Console(Console:info)
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 ...les/setting/cache.go:70:newCacheService() [I] Cache Service Enabled
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 ...les/setting/cache.go:81:newCacheService() [I] Last Commit Cache Service Enabled
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 ...s/setting/session.go:63:newSessionService() [I] Session Service Enabled
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 routers/init.go:128:GlobalInit() [I] SQLite3 Supported
May 05 06:24:22 umbar gitea.web[1503000]: 2020/05/05 06:24:22 routers/init.go:47:checkRunMode() [I] Run Mode: Development
May 05 06:24:23 umbar gitea.web[1503000]: 2020/05/05 06:24:23 cmd/web.go:161:runWeb() [I] Listen: http:https://0.0.0.0:3000
May 05 06:24:23 umbar gitea.web[1503000]: 2020/05/05 06:24:23 ...s/graceful/server.go:55:NewServer() [I] Starting new server: tcp:0.0.0.0:3000 on PID: 1503000

Screenshot of the browser running from the snap
image

Sorry no separate issue was reported, the current snapcraft.yaml seems out of date, "1.9.0+dev-29-gd578b71 " is the last known published version on March 27 2019

Removing some of the complexity, together with the install and
configure hook.

Signed-off-by: Sergio Schvezov <[email protected]>
@popey
Copy link
Contributor

popey commented May 5, 2020

Confirming, I have tested this locally, building the snap on my Ubuntu machine with:

sudo snap install snapcraft --classic --candidate
sudo snap install multipass --classic
snapcraft 

I moved the snap to another machine, installed it with snap install gitea_v1.12.0+gitdev.260.gd08639fe0_amd64.snap --dangerous then pointed the browser at it, and away we go!

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2020
@guillep2k guillep2k added this to the 1.13.0 milestone May 5, 2020
@lafriks lafriks modified the milestones: 1.13.0, 1.12.0 May 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2020
@techknowlogick techknowlogick added the topic/distribution This PR changes something about the packaging of Gitea label May 5, 2020
@zeripath
Copy link
Contributor

zeripath commented May 5, 2020

You may want to take advantage of the LDFLAGS settings here: https://docs.gitea.io/en-us/install-from-source/#changing-the-default-custompath-customconf-and-appworkpath

@zeripath
Copy link
Contributor

zeripath commented May 8, 2020

Make lg-tm work

@zeripath zeripath merged commit b09ec50 into go-gitea:master May 8, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Removing some of the complexity, together with the install and
configure hook.

Signed-off-by: Sergio Schvezov <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment topic/distribution This PR changes something about the packaging of Gitea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants