Allow log.xxx.default to set logging settings for the default logger only

[zeripath]

In #11269 a user wanted to set the default logger to WARN level but leave the rest of the loggers at Info. The current settings require that in order to set this the user would have to add:

[log.file.macaron]
LEVEL = Info

[log.file.router]
LEVEL = Info

[log.file.access]
LEVEL = Info

for each different type logger they want.

This PR allows the user to set [log.file.default] for settings for the default logger only

Signed-off-by: Andrew Thornton [email protected]

[codecov-io]

Codecov Report

Merging #11292 into master will increase coverage by 0.00%.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##           master   #11292   +/-   ##
=======================================
  Coverage   43.96%   43.96%           
=======================================
  Files         614      614           
  Lines       87426    87428    +2     
=======================================
+ Hits        38437    38438    +1     
- Misses      44251    44253    +2     
+ Partials     4738     4737    -1     

Impacted Files	Coverage Δ
modules/setting/log.go	69.64% <40.00%> (+0.27%)	⬆️
services/pull/temp_repo.go	34.18% <0.00%> (-3.42%)	⬇️
modules/git/repo.go	49.79% <0.00%> (-1.26%)	⬇️
models/gpg_key.go	53.95% <0.00%> (+0.52%)	⬆️
modules/queue/unique_queue_disk_channel.go	55.76% <0.00%> (+1.92%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d54479...8f3709c. Read the comment docs.

[silverwind]

Maybe add some info about this to app.ini.sample to make it more discoverable?

[silverwind]

Logging config still feels like black magic to me (for example, I'm still not sure how to get everything logged to stdout only), but I guess this is fine.

[zeripath]

@silverwind it's really not difficult:

[log]
MODE = console
LEVEL = debug
ROOT_PATH = /home/andrew/src/go/gitea/log
REDIRECT_MACARON_LOG = true
MACARON = console
ROUTER = console
XORM = console

If, as is sensible, you don't want the SQL being logged - then set:

[database]
LOG_SQL=false

(I agree it's silly that this isn't the default and that the logging of SQL should only occur at DEBUG level but that's a breaking change which we need to discuss and propose on a PR.)

Say you want to have a specific TRACE level logging for a particular file or area:

[log]
MODE = console, traceconsole
...

[log.traceconsole]
MODE=console
LEVEL=trace
EXPRESSION=compare

The expression will attempt a match against the filename:line:caller, or against the message itself

The difficulties come from if you want logging at level WARN or above only - in which case the additional comments I've put in to the document explain why.

[database]
LOG_SQL=false

...

[log]
MODE = console
LEVEL = info
ROOT_PATH = /home/andrew/src/go/gitea/log
REDIRECT_MACARON_LOG = true
MACARON = console
ROUTER = console
XORM = console

[log.console.default]
LEVEL=warn

Then you will only get main gitea logs at WARN but still get ROUTER, MACARON, and XORM info logs.