Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: milestone: make /milestone/:id endpoint accessible #11264

Merged
merged 2 commits into from
May 3, 2020

Conversation

kevans91
Copy link
Contributor

@kevans91 kevans91 commented May 1, 2020

Previously, this required authentication, but there's not actually
any privileged information on this page. Move the endpoint out of
the group that requires sign-in. It still requires the ability to
read issues and pull requests, so private repositories (for instance)
will not be exposed.

Fixes issue #10312, #11233

Previously, this required authentication, but there's not actually
any privileged information on this page.  Move the endpoint out of
the group that requires sign-in.  It still requires the ability to
read issues and pull requests, so private repositories (for instance)
will not be exposed.

Fixes issue go-gitea#10312, go-gitea#11233
@codecov-io
Copy link

Codecov Report

Merging #11264 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11264   +/-   ##
=======================================
  Coverage   43.29%   43.30%           
=======================================
  Files         605      605           
  Lines       86273    86275    +2     
=======================================
+ Hits        37354    37359    +5     
+ Misses      44314    44313    -1     
+ Partials     4605     4603    -2     
Impacted Files Coverage Δ
routers/routes/routes.go 86.65% <100.00%> (+0.03%) ⬆️
services/pull/patch.go 62.93% <0.00%> (-2.80%) ⬇️
modules/git/repo.go 48.11% <0.00%> (-2.52%) ⬇️
services/pull/check.go 53.04% <0.00%> (-2.44%) ⬇️
services/pull/temp_repo.go 31.62% <0.00%> (ø)
models/issue.go 52.10% <0.00%> (+0.46%) ⬆️
services/pull/pull.go 34.73% <0.00%> (+0.57%) ⬆️
modules/notification/webhook/webhook.go 40.20% <0.00%> (+0.58%) ⬆️
services/pull/update.go 59.32% <0.00%> (+6.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdffef...eaa7890. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2020
@lunny lunny added the type/bug label May 3, 2020
@lunny lunny added this to the 1.12.0 milestone May 3, 2020
@zeripath
Copy link
Contributor

zeripath commented May 3, 2020

make lg-tm work

@zeripath zeripath merged commit 940ed92 into go-gitea:master May 3, 2020
@6543
Copy link
Member

6543 commented May 3, 2020

@kevans91 can you send a backport?

kevans91 added a commit to kevans91/gitea that referenced this pull request May 3, 2020
)

Previously, this required authentication, but there's not actually
any privileged information on this page.  Move the endpoint out of
the group that requires sign-in.  It still requires the ability to
read issues and pull requests, so private repositories (for instance)
will not be exposed.

Fixes go-gitea#10312 
Fixes go-gitea#11233
lafriks pushed a commit that referenced this pull request May 4, 2020
…1282)

Previously, this required authentication, but there's not actually
any privileged information on this page.  Move the endpoint out of
the group that requires sign-in.  It still requires the ability to
read issues and pull requests, so private repositories (for instance)
will not be exposed.

Fixes #10312 
Fixes #11233

Co-authored-by: guillep2k <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
)

Previously, this required authentication, but there's not actually
any privileged information on this page.  Move the endpoint out of
the group that requires sign-in.  It still requires the ability to
read issues and pull requests, so private repositories (for instance)
will not be exposed.

Fixes go-gitea#10312 
Fixes go-gitea#11233
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants