Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sendmail a Process and have default timeout #11256

Merged
merged 4 commits into from
May 2, 2020

Conversation

zeripath
Copy link
Contributor

  • Make sure that sendmail processes register with the process manager
  • Provide a timeout for these (initially of 5 minutes)
  • Add configurable value and tie in to documentation
  • Tie in to the admin config page.

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added the type/enhancement An improvement of existing functionality label Apr 30, 2020
@zeripath zeripath added this to the 1.12.0 milestone Apr 30, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2020
@lunny
Copy link
Member

lunny commented May 2, 2020

CI failed is unrelated.

@zeripath
Copy link
Contributor Author

zeripath commented May 2, 2020

Make lg-tm work

@zeripath zeripath merged commit 4f9d59b into go-gitea:master May 2, 2020
@zeripath zeripath deleted the sendmail-timeout branch May 2, 2020 23:04
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…lt timeout (go-gitea#11256)

* Make sure that sendmail processes register with the process manager
* Provide a timeout for these (initially of 5 minutes)
* Add configurable value and tie in to documentation
* Tie in to the admin config page.

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants