Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: dump: check value of skip-repository flag #11254

Merged
merged 5 commits into from
May 3, 2020
Merged

cmd: dump: check value of skip-repository flag #11254

merged 5 commits into from
May 3, 2020

Conversation

kevans91
Copy link
Contributor

This is a boolean flag; simply checking if it's set isn't enough, we must
check the value as well.

@kevans91
cmd: dump: check value of skip-repository flag
3517b35 
This is a boolean flag; simply checking if it's set isn't enough, we must
check the value as well.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 30, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 30, 2020
@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2020
@guillep2k guillep2k added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 2, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit a5018d0 into go-gitea:master May 3, 2020
@kevans91 kevans91 deleted the skiprepobool branch May 3, 2020 04:04
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@kevans91 @lunny @techknowlogick
cmd: dump: check value of skip-repository flag (go-gitea#11254)
40572af 
This is a boolean flag; simply checking if it's set isn't enough, we must check the value as well.

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kevans91 @guillep2k @lunny @techknowlogick @zeripath @GiteaBot