Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix submit review form #11252

Merged
merged 5 commits into from
Apr 30, 2020
Merged

Fix submit review form #11252

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4b32dd
Fix submit review form
zeripath Apr 29, 2020
227ddfa
placate lint
zeripath Apr 29, 2020
049f074
try something different
zeripath Apr 29, 2020
6a9587d
Update web_src/less/_base.less
zeripath Apr 29, 2020
66b3754
Merge branch 'master' into fix-review-form
techknowlogick Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
try something different 
Signed-off-by: Andrew Thornton <[email protected]>
  • Loading branch information
@zeripath
zeripath committed Apr 29, 2020
commit 049f07426985279fea6df90232683f8f582c0d3f
2 changes: 1 addition & 1 deletion templates/repo/diff/new_review.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<span class="text">{{.i18n.Tr "repo.diff.review"}}</span>
<i class="dropdown icon"></i>
</div>
<div class="menu">
<div class="menu review-box">
<div class="ui clearing segment">
<form class="ui form" action="{{.Link}}/reviews/submit" method="post">
{{.CsrfTokenHtml}}
Expand Down
12 changes: 5 additions & 7 deletions web_src/less/_base.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,19 +1231,17 @@ i.icon.centerlock {

/* limit width of all direct dropdown menu children */
/* https://github.com/go-gitea/gitea/pull/10835 */
.dropdown:not(.selection) > .menu > * {
.dropdown:not(.selection) > .menu:not(.review-box) > * {
max-width: 340px;
zeripath marked this conversation as resolved.
Show resolved Hide resolved
overflow-x: hidden;
text-overflow: ellipsis;
}

.editor-toolbar {
overflow-x: overlay;
}

@media only screen and (max-width: 768px) {
.dropdown:not(.selection) > .menu.review-box > * {
@media only screen and (max-height: 700px) {
.CodeMirror,
.CodeMirror-scroll {
min-height: 200px;
min-height: 100px;
}
}
}
Expand Down