Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow registration via the web form, when AllowOnlyExternalRegistration is True #11248

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

n0emis
Copy link
Contributor

@n0emis n0emis commented Apr 29, 2020

Signed-off-by: n0emis [email protected]

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2020
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Apr 29, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 29, 2020
@lafriks lafriks added type/bug and removed type/enhancement An improvement of existing functionality labels Apr 29, 2020
@zeripath zeripath merged commit 33738ff into go-gitea:master Apr 29, 2020
@n0emis n0emis deleted the fix_AllowOnlyExternalRegistration branch April 29, 2020 23:39
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…istration is True (go-gitea#11248)

* Don't allow registration via the web form, when AllowOnlyExternalRegistration is True

* Show Disabled Registration message if DisableRegistration or AllowOnlyExternalRegistration options are true
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants