Add EventSource support #11235
Merged
Add EventSource support #11235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the browser supports EventSource switch to use this instead of polling notifications. Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
guillep2k
reviewed
Apr 29, 2020
GiteaBot
added
the
lgtm/need 2
|
This does seem to add quite a bit of backend code. Did you consider a third-party SSE implementation? |
|
@silverwind there was genuinely nothing appropriate - and not dead already - and we'd just have to do more work to shim around it. |
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
|
@zeripath what is event-stream? suggest add more detail description or screenshoots about this feature. Thanks |
|
@a1012112796 I've updated the head. |
guillep2k
reviewed
Apr 30, 2020
guillep2k
reviewed
May 1, 2020
zeripath
commented
May 1, 2020
Co-authored-by: guillep2k <[email protected]>
zeripath
commented
May 1, 2020
zeripath
commented
May 1, 2020
zeripath
commented
May 1, 2020
zeripath
commented
May 1, 2020
zeripath
commented
May 1, 2020
zeripath
commented
May 1, 2020
zeripath
commented
May 1, 2020
Signed-off-by: Andrew Thornton <[email protected]>
guillep2k
reviewed
May 1, 2020
|
guillep2k
approved these changes
May 5, 2020
GiteaBot
added
lgtm/need 1
silverwind
reviewed
May 7, 2020
silverwind
reviewed
May 7, 2020
silverwind
approved these changes
May 7, 2020
GiteaBot
added
lgtm/done
|
Make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
If the browser supports EventSource switch to use this instead of polling notifications. Signed-off-by: Andrew Thornton [email protected]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the browser supports
EventSourceswitch to use this instead ofpolling notifications.
Signed-off-by: Andrew Thornton [email protected]
What is an EventSource?
See https://developer.mozilla.org/en-US/docs/Web/API/EventSource
It's used for Server-Side Events notification.
Creating an EventSource causes JS to open a long-standing request, in this case to
${AppSubUrl}/user/eventswith the expected mime-typetext/event-stream. In this PR we use this stream to obtain a updated count of notifications. However, future extensions of this work could use this along with https://fomantic-ui.com/modules/toast.html to give users a running update of their dashboard.Using the event-stream we could add in error and task information for long running things - e.g. report when migrations and mirroring are complete, or errors from cron tasks.
We can further use the stream to alert that they have logged on to a different browser/device and logged out from those.
In my testing on Chrome only one EventSource is opened per target-url per browser session. So if you have multiple tabs open for Gitea there will only be one EventSource.