Refactor Milestone related

[6543]

as title

moved from #10148 to have a smaler diff for it

[codecov-io]

Codecov Report

Merging #11225 into master will increase coverage by 0.01%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master   #11225      +/-   ##
==========================================
+ Coverage   43.96%   43.97%   +0.01%     
==========================================
  Files         613      613              
  Lines       87347    87333      -14     
==========================================
+ Hits        38399    38404       +5     
+ Misses      44215    44199      -16     
+ Partials     4733     4730       -3     

Impacted Files	Coverage Δ
routers/repo/milestone.go	0.00% <0.00%> (ø)
routers/api/v1/repo/milestone.go	32.22% <50.00%> (ø)
models/issue_milestone.go	67.46% <86.54%> (-1.51%)	⬇️
modules/convert/issue.go	85.00% <100.00%> (+2.30%)	⬆️
routers/user/home.go	59.90% <100.00%> (ø)
modules/process/manager.go	74.69% <0.00%> (-3.62%)	⬇️
modules/git/repo.go	49.79% <0.00%> (-1.26%)	⬇️
models/gpg_key.go	53.42% <0.00%> (-0.53%)	⬇️
services/pull/pull.go	33.77% <0.00%> (+0.57%)	⬆️
models/unit.go	44.44% <0.00%> (+2.46%)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00e62c...88e2690. Read the comment docs.

[6543]

ping lgtm - it now need only 1 lgtm

[zeripath]

make lg-tm work

[techknowlogick]

@6543 please update to latest master, or check allow edits from maintainers.

[zeripath]

Make lg-tm work