-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using API CreateRelease set created_unix to the tag commit time #11218
Conversation
pleace "update" this branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but the current behavior looks kind of fishy... almost intended. Can this be considered a matter of preference? This PR will not affect just the API.
same thought - but think this behaviour more intuetive - to controle it via an option would probably be the best ... |
@jasder change this pull so it can be controled via option |
A release is based on a tag, but should release created time be the same as the tag time? Since tag time has been saved on git, so it's unnecessary to save it again in the database. |
@lunny But release's the return created time is based on release, and rend directly from the database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think this makes sense.
Codecov Report
@@ Coverage Diff @@
## master #11218 +/- ##
==========================================
+ Coverage 43.29% 43.30% +0.01%
==========================================
Files 605 605
Lines 86246 86246
==========================================
+ Hits 37340 37351 +11
+ Misses 44305 44301 -4
+ Partials 4601 4594 -7
Continue to review full report at Codecov.
|
So somewhat related, in that this shouldn't be set when a tag is already set (before it didn't matter since it was going by the commit date that the tag pointed to): #12341. Please make backport to 1.12 if possible. |
When creating a release with api, the release time of the version is wrong(is actually the user's update time)
Ex: