Add a 'this' to issue close/reopened messages #11204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
changed the title
|
For better adaptability we could have separate messages for PRs. |
GiteaBot
added
the
lgtm/need 2
|
Hmm, I think I still have a slight preference for the shorter |
I don't mean the messages should be different in English, only that they should have different entries in case other languages require e.g. gender diferentiation. |
|
Updated as suggested:
|
zeripath
approved these changes
Apr 29, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Apr 30, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #11204 +/- ##
==========================================
+ Coverage 43.29% 43.30% +0.01%
==========================================
Files 605 605
Lines 86246 86246
==========================================
+ Hits 37340 37352 +12
+ Misses 44305 44298 -7
+ Partials 4601 4596 -5
Continue to review full report at Codecov.
|
|
make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* add a 'this' to issue close/reopened messages * add 'this issue/pull request' and create new localization entries Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change english message on issue closure/reopen from
<user> closed nowto<user> closed this nowto match GitHub.Is it sufficient like this for other locales to eventually be updated as well?