Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On logout force redirect to start page #11202

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Conversation

colorfulberry
Copy link
Contributor

when one user logout should clear redirect to value, otherwise switch the account will occur error.

Please check the following:

  1. Make sure you are targeting the master branch, pull requests on release branches are only allowed for bug fixes.
  2. Read contributing guidelines: https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md
  3. Describe what your pull request does and which issue you're targeting (if any)

You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.

when one user logout should clear redirect to value, otherwise switch the account will occur error.
@6543
Copy link
Member

6543 commented Apr 24, 2020

@colorfulberry can you pleace rename this pull title to a more usefull one?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2020
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but still this need a better title!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2020
@lafriks lafriks changed the title Update auth.go Clear redirect cookie after logout Apr 25, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #11202 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11202      +/-   ##
==========================================
- Coverage   43.23%   43.22%   -0.02%     
==========================================
  Files         604      604              
  Lines       86003    86004       +1     
==========================================
- Hits        37184    37175       -9     
- Misses      44233    44241       +8     
- Partials     4586     4588       +2     
Impacted Files Coverage Δ
routers/user/auth.go 11.38% <100.00%> (+0.07%) ⬆️
modules/indexer/stats/db.go 40.62% <0.00%> (-18.75%) ⬇️
modules/indexer/stats/queue.go 62.50% <0.00%> (-18.75%) ⬇️
modules/git/utils.go 65.67% <0.00%> (-4.48%) ⬇️
modules/queue/workerpool.go 56.93% <0.00%> (-1.07%) ⬇️
modules/git/repo.go 51.04% <0.00%> (+0.41%) ⬆️
services/pull/pull.go 34.73% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e008b68...694dbf8. Read the comment docs.

@zeripath zeripath merged commit f1f56da into go-gitea:master Apr 25, 2020
@zeripath zeripath changed the title Clear redirect cookie after logout On logout force redirect to start page Apr 25, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…11202)

when one user logout should clear redirect to value, otherwise switch the account will occur error.

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants