Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS dependencies, highlight.js 10.0.0 #11195

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Update JS dependencies, highlight.js 10.0.0 #11195

merged 4 commits into from
Apr 24, 2020

Conversation

silverwind
Copy link
Member

@silverwind
Update JS dependencies, highlight.js 10.0.0
868d977 
Breaking changes in higlight.js do not affect us.
6543
6543 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested works

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 23, 2020
@6543
Copy link
Member

6543 commented Apr 23, 2020

a question related to highlightjs: do we already use "Web Worker" mode ?

@silverwind
Copy link
Member Author

silverwind commented Apr 24, 2020 •
edited

Yes web worker is used since #11017.

Of note here: The changelog says IE11 no longer works but I believe this is not true in our case because we transpile. But I'll give it a test in that browser later.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2020
@sapk sapk added this to the 1.12.0 milestone Apr 24, 2020
@silverwind
Copy link
Member Author

Gave it a go in IE11. Syntax highlighting is already broken on master in it and all it logs is

SCRIPT0: Syntax error
blob:70400007-61CE-4F5D-B229-6657B357E693 (1,1)

Adding fallback: true to worker-loader does not fix it, and neither does writing the worker script in ES5. I guess we can count it as "graceful degradation".

Anyways, I think this PR does not add new regressions, so should be good to go.

@sapk sapk added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 24, 2020
@sapk
Copy link
Member

sapk commented Apr 24, 2020

Make lgtm work.

@sapk sapk merged commit e008b68 into go-gitea:master Apr 24, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind @sapk @lafriks
Update JS dependencies, highlight.js 10.0.0 (go-gitea#11195)
e2f25e0 
Breaking changes in higlight.js do not affect us.

Co-authored-by: Antoine GIRARD <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@sapk sapk sapk approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @6543 @sapk @lafriks @GiteaBot