[ui] Chang icon type for review action in action page #11191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
a1012112796
commented
Apr 23, 2020
a1012112796
commented
- as title, do same changs on action view with [UI] change review status icons on pr view style to github style #10737
- chage default icon from "invalid type" to "question" , because "invalid type" is not a meaningfull icon type
* as title, do same changs on action view with go-gitea#10737 * chage default icon from "invalid type" to "question" , because "invalid type" is not a meaningfull icon type Signed-off-by: a1012112796 <[email protected]>
silverwind
approved these changes
Apr 23, 2020
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Apr 23, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #11191 +/- ##
==========================================
+ Coverage 43.34% 43.37% +0.03%
==========================================
Files 601 601
Lines 85694 85694
==========================================
+ Hits 37146 37172 +26
+ Misses 43963 43943 -20
+ Partials 4585 4579 -6
Continue to review full report at Codecov.
|
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* as title, do same changs on action view with go-gitea#10737 * chage default icon from "invalid type" to "question" , because "invalid type" is not a meaningfull icon type Signed-off-by: a1012112796 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.