Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable ENABLE_HARD_LINE_BREAK by default #11162

Merged
merged 5 commits into from
Apr 21, 2020
Merged

enable ENABLE_HARD_LINE_BREAK by default #11162

merged 5 commits into from
Apr 21, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 20, 2020 •
edited
Loading

This matches GitHub's rendering.

Fixes: #11155

zeripath
zeripath approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I think this means that we may need to mark this as a breaking change.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2020
@zeripath zeripath added pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! topic/ui Change the appearance of the Gitea UI labels Apr 20, 2020
@zeripath zeripath added this to the 1.12.0 milestone Apr 20, 2020
@silverwind
Copy link
Member Author

Yeah, it will be "breaking" for users that don't specify the option in their config.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2020
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit 7e20f1c into go-gitea:master Apr 21, 2020
@silverwind silverwind deleted the hardwraps branch April 22, 2020 12:42
@zeripath zeripath mentioned this pull request May 19, 2020
Closed
zeripath added a commit to zeripath/gitea that referenced this pull request May 19, 2020
@zeripath
Revert "enable ENABLE_HARD_LINE_BREAK by default (go-gitea#11162)"
66dafdd 
This reverts commit 7e20f1c.

This commit causes Gitea to diverge from Github not move towards it
and should be reverted
@silverwind silverwind mentioned this pull request May 20, 2020
Merged
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind
enable ENABLE_HARD_LINE_BREAK by default (go-gitea#11162)
ad6443c 
enable ENABLE_HARD_LINE_BREAK by default

This matches GitHub's rendering.

Fix go-gitea#11155
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Markdown parser should respect single newlines
4 participants
@silverwind @zeripath @lafriks @GiteaBot