Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API EditIssue and EditPullRequest issue notifications #11123

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 18, 2020

Restructure models.UpdateIssueByAPI and EditIssue/EditPullRequest to issue notifications

Fix #10014

Signed-off-by: Andrew Thornton [email protected]

Restructure models.UpdateIssueByAPI and EditIssue/EditPullRequest
to issue notifications

Fix go-gitea#10014

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.12.0 milestone Apr 18, 2020
models/issue.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 18, 2020
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2020
@6543
Copy link
Member

6543 commented Apr 18, 2020

@zeripath thanks for taking care of this issue it got out of my eyes

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2020
models/issue.go Show resolved Hide resolved
routers/api/v1/repo/issue.go Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented May 2, 2020

Please resolve the conflicts.

Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think my comments are relevant, but they are issues of style and not really blockers; otherwise looks good 👍

@codecov-io
Copy link

Codecov Report

Merging #11123 into master will increase coverage by 0.01%.
The diff coverage is 45.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11123      +/-   ##
==========================================
+ Coverage   43.97%   43.98%   +0.01%     
==========================================
  Files         613      613              
  Lines       87333    87371      +38     
==========================================
+ Hits        38404    38431      +27     
- Misses      44200    44208       +8     
- Partials     4729     4732       +3     
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 33.51% <0.00%> (-0.29%) ⬇️
models/issue.go 52.67% <53.48%> (+0.25%) ⬆️
routers/api/v1/repo/issue.go 58.13% <64.28%> (+1.13%) ⬆️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
modules/git/repo.go 51.88% <0.00%> (ø)
services/pull/pull.go 33.39% <0.00%> (+0.19%) ⬆️
modules/log/event.go 65.64% <0.00%> (+1.02%) ⬆️
modules/indexer/stats/db.go 59.37% <0.00%> (+9.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9dc3bc...f41d85b. Read the comment docs.

@lafriks lafriks merged commit 414c9ee into go-gitea:master May 16, 2020
@zeripath zeripath deleted the fix-10014-send-IssueTitleChangedCommit branch May 16, 2020 21:11
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…11123)

* Make API EditIssue and EditPullRequest issue notifications

Restructure models.UpdateIssueByAPI and EditIssue/EditPullRequest
to issue notifications

Fix go-gitea#10014

Signed-off-by: Andrew Thornton <[email protected]>

* As per @6543

Signed-off-by: Andrew Thornton <[email protected]>

* update status!

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: John Olheiser <[email protected]>
Co-authored-by: guillep2k <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: change Issue name doesnt create a IssueTitleChangedComment
10 participants