Add branch delete to API #11112
Merged
Add branch delete to API #11112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
force-pushed
the
add-api-delete-branch_11070
branch
from
c1a64b7
to
95a6b84
Compare
techknowlogick
added
modifies/api
guillep2k
reviewed
Apr 18, 2020
GiteaBot
added
the
lgtm/need 2
|
@guillep2k done |
guillep2k
approved these changes
Apr 18, 2020
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #11112 +/- ##
==========================================
+ Coverage 43.42% 43.44% +0.01%
==========================================
Files 600 600
Lines 85022 85108 +86
==========================================
+ Hits 36922 36972 +50
- Misses 43541 43567 +26
- Partials 4559 4569 +10
Continue to review full report at Codecov.
|
lunny
approved these changes
Apr 19, 2020
GiteaBot
added
lgtm/done
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* use same process as in routers/repo/branch.go/deleteBranch * make sure default branch can not be deleted * remove IsDefaultBranch from UI process - it is worth its own pull * permissions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title
DELETE /repos/{owner}/{repo}/branches/{branch}added default branch delete protection to UI function too (should be prefented by template but now go-code take care of it too)-> #11115close #11070