Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetReviews() to RetryDownloader #11093

Merged
merged 9 commits into from
Apr 20, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 16, 2020

as title

@lunny pleace have a look at this

@jolheiser jolheiser added this to the 1.12.0 milestone Apr 16, 2020
@codecov-io
Copy link

Codecov Report

Merging #11093 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11093      +/-   ##
==========================================
+ Coverage   43.42%   43.44%   +0.01%     
==========================================
  Files         600      600              
  Lines       85022    85034      +12     
==========================================
+ Hits        36922    36939      +17     
+ Misses      43541    43539       -2     
+ Partials     4559     4556       -3     
Impacted Files Coverage Δ
modules/migrations/base/downloader.go 23.93% <0.00%> (-2.74%) ⬇️
modules/indexer/stats/db.go 50.00% <0.00%> (-18.75%) ⬇️
modules/git/utils.go 65.67% <0.00%> (-4.48%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
modules/git/repo.go 51.04% <0.00%> (+0.41%) ⬆️
models/issue.go 51.95% <0.00%> (+0.46%) ⬆️
models/gpg_key.go 53.95% <0.00%> (+0.52%) ⬆️
modules/notification/webhook/webhook.go 40.20% <0.00%> (+0.58%) ⬆️
services/pull/pull.go 33.96% <0.00%> (+0.76%) ⬆️
services/pull/check.go 52.43% <0.00%> (+2.43%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef11ff...4a23a3f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2020
@zeripath
Copy link
Contributor

Make lg-tm work

@zeripath zeripath merged commit e37e217 into go-gitea:master Apr 20, 2020
@zeripath zeripath changed the title [Fix] RetryDownloader (add GetReviews()) Add GetReviews() to RetryDownloader Apr 20, 2020
@6543 6543 deleted the fix-retryDownloader branch April 20, 2020 02:34
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* add GetReviews() to RetryDownloader
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants