Align review-item svg octicons

[CirnoT]

Aligns svg octicons in review-item properly.

Before:

After:

This also solves the issue where different icon types (image and svg) are not aligned

Before:

After:

[silverwind]

I see unequal padding in that box, e.g. there's more padding below the text than on top. I think this may be elegantly solved via flexbox instead of more pixel hacks. Put the left- and right-aligned content into a flexbox with justify-content: space-between and make those two children another flexbox with align-items: center for vertical alignment.

[CirnoT]

I don't see any unequal padding after the removal of pixel hack.

[guillep2k]

Is it me or the hourglass is still slightly misaligned?

[CirnoT]

This is due to icon size vs svg element size. I am sure this can be somehow solved but I am unsure how. Reluctant to add more pixel hacks as they rely on icon sizes which might change later (which I believe was the cause for this issue in the first place)

[CirnoT]

Put the left- and right-aligned content into a flexbox with justify-content: space-between and make those two children another flexbox with align-items: center for vertical alignment.

That would require significant refactoring of template, as currently both left and right aligned element are just shoved in and it's CSS job to align them (ie. the template doesn't know what should be left or right).

[silverwind]

I don't see any unequal padding

The text line is just so slightly pushed 1 or 2 px to the top, presumably because of the icons. Proper fix will be flexbox, but I guess this is still a improvement until then.

[6543]

as silverwind wrote ... better than nothing

[6543]

ping lgtm

[guillep2k]

Ping LG-TM