-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Add MergePull comment type instead of close for merge PR #11058
Conversation
Signed-off-by: a1012112796 <[email protected]>
Have you checked |
Hello, I think this change only about comment, it haven't do any change on notify and actions. |
Every time you create a comment, a notification is derived from that comment; and comment types (you've just added one) are important for the mail template system. I don't expect a problem in this case, but it doesn't hurt to check. |
This comment has been minimized.
This comment has been minimized.
OK ... to track when it was merged if the conversation in a pull goes on |
lgtm bot ? |
make L-G-T-M work |
…a#11058) Signed-off-by: a1012112796 <[email protected]> Co-authored-by: Lauris BH <[email protected]>
As title.
view: