consolidate author name across timeline #11053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep2k
added
type/enhancement
|
Please undo the changes to all locales except |
GiteaBot
added
the
lgtm/need 2
Sorien
force-pushed
the
prettify-timeline-2
branch
from
480da4c
to
9ceffe9
Compare
|
@guillep2k done |
lafriks
approved these changes
Apr 13, 2020
GiteaBot
added
lgtm/need 1
guillep2k
reviewed
Apr 13, 2020
lunny
added
the
pr/breaking
|
This will break other languages translations. |
|
@lunny but I don't think that makes this PR breaking |
mrsdizzie
approved these changes
Apr 15, 2020
GiteaBot
added
lgtm/done
silverwind
approved these changes
Apr 17, 2020
6543
approved these changes
Apr 17, 2020
|
I don't think this is breaking because we have changed translations before like this and not marked it breaking. I know translations will be empty for this option in other languages, but in crowdin once put back in it'll be the same. |
|
well at this point old v1.11 versions cant just copy current locales from master |
lafriks
removed
the
pr/breaking
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* consolidate author name across timeline * Sync with master Co-authored-by: John Olheiser <[email protected]> Co-authored-by: guillep2k <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is trying to fix different visuals of user's name in the timeline (see images below) I was experimenting with different styles and size but GH's is looking best.
before
after
it's one of many UI changes after #10972