-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor UpdateOAuth2Application #11034
Merged
zeripath
merged 6 commits into
go-gitea:master
from
6543-forks:refactor-UpdateOAuth2Application
Apr 30, 2020
Merged
Refactor UpdateOAuth2Application #11034
zeripath
merged 6 commits into
go-gitea:master
from
6543-forks:refactor-UpdateOAuth2Application
Apr 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
force-pushed
the
refactor-UpdateOAuth2Application
branch
from
April 10, 2020 01:51
30405a0
to
919b7d7
Compare
6543
commented
Apr 10, 2020
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 10, 2020
techknowlogick
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Apr 11, 2020
thx @techknowlogick |
Codecov Report
@@ Coverage Diff @@
## master #11034 +/- ##
==========================================
+ Coverage 43.42% 43.46% +0.03%
==========================================
Files 600 600
Lines 85022 85026 +4
==========================================
+ Hits 36922 36954 +32
+ Misses 43541 43517 -24
+ Partials 4559 4555 -4
Continue to review full report at Codecov.
|
lafriks
approved these changes
Apr 27, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Apr 27, 2020
this pull is failing now because of a strange merge behaviour - I'll rebase it |
6543
force-pushed
the
refactor-UpdateOAuth2Application
branch
from
April 27, 2020 22:17
806fb33
to
de066c4
Compare
adelowo
approved these changes
Apr 28, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 28, 2020
make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Following on from go-gitea#11008 refactor UpdateOAuth2Application
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title come up in #11008