Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui:Add flash notify for email preference seting success #11027

Merged
merged 3 commits into from
Apr 9, 2020
Merged

ui:Add flash notify for email preference seting success #11027

merged 3 commits into from
Apr 9, 2020

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Apr 9, 2020 •
edited

As title :)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 9, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 9, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 9, 2020
@a1012112796 @lafriks
add review suggest changes
eedd332 
Co-authored-by: Lauris BH <[email protected]>

Co-Authored-By: Lauris BH <[email protected]>
@a1012112796 a1012112796 requested a review from lafriks April 9, 2020 14:04
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 9, 2020
@gary-kim
Copy link
Member

gary-kim commented Apr 9, 2020 •
edited

Hello LGTM?

EDIT: There we go!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 9, 2020
@techknowlogick techknowlogick merged commit ca714db into go-gitea:master Apr 9, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@a1012112796 @lafriks
ui:Add flash notify for email preference seting success (go-gitea#11027)
ec4b9a9 
* Add flash notify for email preference seting success

Signed-off-by: a1012112796 <[email protected]>

* add review suggest changes

Co-authored-by: Lauris BH <[email protected]>

Co-Authored-By: Lauris BH <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@gary-kim gary-kim gary-kim approved these changes

@lafriks lafriks Awaiting requested review from lafriks

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@a1012112796 @gary-kim @lafriks @6543 @techknowlogick @GiteaBot